-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydoit compatibility for nbflow #5
base: master
Are you sure you want to change the base?
Conversation
Thanks! Let's loop @joestubbs too who was thinking of working on exactly this as well. |
@@ -0,0 +1,7 @@ | |||
# Example nbflow setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we actually kept just a single example that can be run multiple ways -- so if we have the SConstruct
and dodo.py
side-by-side and users can either run scons
or doit
depending on which system they want to try. Then we also don't need to maintain multiple almost identical examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point; done.
Thanks for looping me in! I wrote a pydoit.py module with a setup function as we discussed, and the original workflow example builds successfully, but I hadn't added any additional tests. My implementation doesn't add pydoit to the requirements; rather, it assumes the user has installed it themselves and has their own dodo.py file (or task loader) that they can complement with the setup function. If this would be of use I'm happy to make it available - just let me know. |
…ction of travis yml
Hi! |
Hello there!
I like to use pydoit as my build system; it supports Python3 and is quite extensible. This PR adds a module to
nbflow
for pydoit.The folder
doit-example
shows how it works. It uses adodo.py
file, which follows a similar pattern to the scons example:Major kudos for your arch making this really easy to write!
Todos:
nbflow-doit
Cheers,
Camille