Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent stack trace on the course of error #113

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

jamesgeorge007
Copy link
Owner

@jamesgeorge007 jamesgeorge007 commented Sep 27, 2023

It is difficult to debug when the workflow fails since the internal stack trace is what gets logged currently. For instance, #112. This PR aims at fixing this behaviour by logging the content of the stderr stream instead.

Before

before

After

after

@tuunit
Copy link
Collaborator

tuunit commented Sep 27, 2023

I'll give this a review tomorrow ;)

index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuunit tuunit merged commit a38649b into master Sep 29, 2023
2 checks passed
@jamesgeorge007 jamesgeorge007 deleted the hotfix/prevent-stack-traces branch September 29, 2023 11:57
@jamesgeorge007
Copy link
Owner Author

@tuunit, let's use squash and merge unless the PR includes commits from multiple authors, for instance, #97.

@tuunit
Copy link
Collaborator

tuunit commented Sep 29, 2023

@jamesgeorge007 so you want to always squash every merge to a single commit with a message following conventional commits correct? Regarding multiple authors. Do you want to keep multiple commits and change each commit per author to a conventional commit message or do you want to squash it as well and just add @Co-authored-by username? https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

@jamesgeorge007
Copy link
Owner Author

When multiple PRs get merged to a feature branch and thereafter to the default branch let's preserve the individual commits and use rebase and merge like in the case with #97. The idea is to have one commit associated with a feature.

In other cases, let's use squash and merge (regardless of it is to the default/feature branch) like with the case of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants