-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent stack trace on the course of error #113
Conversation
I'll give this a review tomorrow ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jamesgeorge007 so you want to always squash every merge to a single commit with a message following conventional commits correct? Regarding multiple authors. Do you want to keep multiple commits and change each commit per author to a conventional commit message or do you want to squash it as well and just add |
When multiple PRs get merged to a feature branch and thereafter to the default branch let's preserve the individual commits and use rebase and merge like in the case with #97. The idea is to have one commit associated with a feature. In other cases, let's use squash and merge (regardless of it is to the default/feature branch) like with the case of this PR. |
It is difficult to debug when the workflow fails since the internal stack trace is what gets logged currently. For instance, #112. This PR aims at fixing this behaviour by logging the content of the stderr stream instead.
Before
After