Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support string uidType #84

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

derekwsgray
Copy link

PR that adds 'string' as an allowable relationship uidType.

Regarding: #83

@championswimmer
Copy link
Member

awesome!!

@championswimmer
Copy link
Member

you can ignore the travis failure, i'll update the dependencies

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

Merging #84 into master will increase coverage by <.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   94.94%   94.95%   +<.01%     
==========================================
  Files          64       64              
  Lines        1782     1784       +2     
==========================================
+ Hits         1692     1694       +2     
  Misses         90       90
Impacted Files Coverage Δ
lib/responseHelper.js 97.56% <ø> (ø) ⬆️
lib/postProcess.js 96.87% <100%> (ø) ⬆️
lib/routes/related.js 100% <100%> (ø) ⬆️
lib/routes/addRelation.js 100% <100%> (ø) ⬆️
lib/ourJoi.js 87.5% <40%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30df113...0b8a0b7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants