Added LeveledMeterProvider to telemetry setting

[chahatsagarmain]

Which problem is this PR solving?

• Fixes [jaeger-v2] Add Meter Provider To Telemetry Settings #6127

How was this change tested?

• make lint test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (f0a1776) to head (1604786).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6173      +/-   ##
==========================================
+ Coverage   96.49%   96.51%   +0.02%     
==========================================
  Files         354      354              
  Lines       20127    20134       +7     
==========================================
+ Hits        19421    19433      +12     
+ Misses        522      518       -4     
+ Partials      184      183       -1     

Flag	Coverage Δ
badger_v1	8.31% <0.00%> (ø)
badger_v2	1.67% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v1	14.39% <0.00%> (ø)
cassandra-4.x-v2	1.61% <0.00%> (-0.01%)	⬇️
cassandra-5.x-v1	14.39% <0.00%> (ø)
cassandra-5.x-v2	1.61% <0.00%> (-0.01%)	⬇️
elasticsearch-6.x-v1	18.60% <0.00%> (ø)
elasticsearch-7.x-v1	18.68% <0.00%> (ø)
elasticsearch-8.x-v1	18.85% <0.00%> (+<0.01%)	⬆️
elasticsearch-8.x-v2	1.67% <0.00%> (-0.01%)	⬇️
grpc_v1	9.46% <57.14%> (-0.02%)	⬇️
grpc_v2	6.99% <0.00%> (-0.02%)	⬇️
kafka-v1	8.88% <0.00%> (ø)
kafka-v2	1.67% <0.00%> (-0.01%)	⬇️
memory_v2	1.67% <0.00%> (-0.01%)	⬇️
opensearch-1.x-v1	18.73% <0.00%> (+<0.01%)	⬆️
opensearch-2.x-v1	18.72% <0.00%> (ø)
opensearch-2.x-v2	1.67% <0.00%> (+<0.01%)	⬆️
tailsampling-processor	0.46% <0.00%> (-0.01%)	⬇️
unittests	95.43% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chahatsagarmain]

@mahadzaryab1 how will i propogate leveledmeterprovider where telset is not part of function arguement ? Do i just use noop meterprovider there ?

[mahadzaryab1]

@mahadzaryab1 how will i propogate leveledmeterprovider where telset is not part of function arguement ? Do i just use noop meterprovider there ?

Yes, it will not be available in the context of v1 so a noop provider can be used there.

[mahadzaryab1]

nice work - just a couple of nits

[mahadzaryab1]

lgtm but need to wait for @yurishkuro's approval

[yurishkuro]

I don't think this is addressing all places

$ rg otel/metric/noop
cmd/query/app/server.go
22:	"go.opentelemetry.io/otel/metric/noop"

plugin/storage/grpc/factory.go
21:	noopmetric "go.opentelemetry.io/otel/metric/noop"

cmd/collector/app/handler/otlp_receiver.go
24:	noopmetric "go.opentelemetry.io/otel/metric/noop"

cmd/collector/app/handler/zipkin_receiver.go
16:	noopmetric "go.opentelemetry.io/otel/metric/noop"

[mahadzaryab1]

@yurishkuro (1) looks to be addressed in this PR. (3) and (4) are v1 components so we're passing in noop (https://github.com/jaegertracing/jaeger/blob/main/cmd/collector/app/handler/otlp_receiver.go#L71-L81). Is there anything else we can do for that?

@chahatsagarmain for (2) We can pass the meter provider down from this constructor and into the grpc factory.

[mahadzaryab1]

just one more comment

[yurishkuro]

Use the opportunity to simplify the signature:

Suggested change

	metricsFactory metrics.Factory,
	logger *zap.Logger,
	host component.Host,
	meterProvider metric.MeterProvider,
	telset telemetry.Settings,

[yurishkuro]

I meant Jaeger's internal telemetry.Settings, which includes both host and metrics factory

[chahatsagarmain]

telset := telemetery.Setting{ Logger: s.telset.Logger, Host: host, Metrics: mf, LeveledMeterProvider: func(_ configtelemetry.Level) metric.MeterProvider { return s.telset.MeterProvider }, }

[chahatsagarmain]

can i pass meter provider like this ? or should i have a field to pass meter provider in function signature ?

[yurishkuro]

yes that's fine (ie to ignore the level)

[chahatsagarmain]

@yurishkuro spm test is failing for recent prs