K8s integration test for hotrod #6155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6155 +/- ##
==========================================
- Coverage 96.50% 96.49% -0.02%
==========================================
Files 354 354
Lines 20127 20127
==========================================
- Hits 19424 19421 -3
- Misses 520 522 +2
- Partials 183 184 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Nov 3, 2024
| if [[ -n "${JAEGER_PORT_FWD_PID:-}" ]]; then | ||
| kill "$JAEGER_PORT_FWD_PID" || true | ||
| fi | ||
| kubectl delete namespace example-hotrod --ignore-not-found=true |
There was a problem hiding this comment.
can we also dump the logs if unsuccessful?
yurishkuro
added
the
changelog:ci
Signed-off-by: chahatsagarmain <[email protected]>
|
@yurishkuro I have made the necessary changes |
yurishkuro
reviewed
Nov 14, 2024
scripts/build-hotrod-image.sh
Outdated
| if [[ "$success" == "false" ]]; then | ||
| dump_logs "${docker_compose_file}" | ||
| dump_logs "${docker_compose_file}" |
There was a problem hiding this comment.
logs should be dumped before you bring down containers
|
needs a rebase |
Signed-off-by: chahat sagar <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Signed-off-by: chahatsagarmain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test