Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to Docker from master even without a tag #1953

Merged
merged 1 commit into from
Nov 30, 2019

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Resolves #1952. We used to publish snapshots on all commits to master, but now seem to only publish on tags, likely after https://github.com/jaegertracing/jaeger/pull/1909/files#diff-aeee4566b9eb012ce98bd3578f7740a3L26.

Short description of the changes

There is a call to ./scripts/travis/upload-all-docker-images.sh from before_deploy, but deploy is configured to only run on a tag, so before_deploy is probably also skipped on master. Moving this step back into script.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1953 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
- Coverage   98.46%   98.44%   -0.03%     
==========================================
  Files         199      199              
  Lines        9875     9875              
==========================================
- Hits         9723     9721       -2     
- Misses        116      117       +1     
- Partials       36       37       +1
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 99.2% <0%> (-0.8%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0938d...e5d624d. Read the comment docs.

@yurishkuro yurishkuro merged commit e4b97b3 into jaegertracing:master Nov 30, 2019
@yurishkuro yurishkuro deleted the fix-1952 branch November 30, 2019 19:27
@pavolloffay pavolloffay added this to the Release 1.16 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing latest image is broken
2 participants