Deploy to Docker from master even without a tag #1953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #1952. We used to publish snapshots on all commits to master, but now seem to only publish on tags, likely after https://github.com/jaegertracing/jaeger/pull/1909/files#diff-aeee4566b9eb012ce98bd3578f7740a3L26.
Short description of the changes
There is a call to
./scripts/travis/upload-all-docker-images.sh
frombefore_deploy
, butdeploy
is configured to only run on a tag, sobefore_deploy
is probably also skipped on master. Moving this step back intoscript
.