Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature page for custom ca integration using k8s CSR #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaellio
Copy link
Contributor

@jaellio jaellio commented Mar 17, 2023

Resolves #142

Questions:

  • Who the primary leads are for this feature?
  • Is there an RFC for this feature?

@istio-testing
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-policy-bot
Copy link

😊 Welcome @jaellio! This is either your first contribution to the Istio enhancements repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2023
@jaellio jaellio marked this pull request as ready for review March 17, 2023 19:17
@jaellio jaellio requested review from a team as code owners March 17, 2023 19:17
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 17, 2023
Custom CA Integration using Kubernetes CSR
[//]: # (The name of the feature, e.g. Multiple control planes)

**Primary lead(s):**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to be the primary lead? @jaellio

[//]: # (An RFC is mandatory to graduate to experimental. The RFC does not have to be reviewed in a work group)
[//]: # (meeting to graduate to experimental.)

- [X] [Documentation](insert_your_link_here) for enabling and using the feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have a link to add here?

Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a space between [] to enable it becoming a check box


**Design**

- [] RFC has been approved describing the intention of the feature as well as the user stories behind the feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [] RFC has been approved describing the intention of the feature as well as the user stories behind the feature.
- [ ] RFC has been approved describing the intention of the feature as well as the user stories behind the feature.


**Config**

- [] Explicit user action is required to enable this feature (e.g. a config field, config resource, or installation action).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [] Explicit user action is required to enable this feature (e.g. a config field, config resource, or installation action).
- [ ] Explicit user action is required to enable this feature (e.g. a config field, config resource, or installation action).

Comment on lines +115 to +121
- [] Reference docs are published to preliminary.istio.io or the Istio wiki.

- [] Basic feature docs are published on preliminary.istio.io describing what the feature does, how to use it, and any caveats.

- [] Release notes entries added as appropriate

- [] Upgrade notes entries added as appropriate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [] Reference docs are published to preliminary.istio.io or the Istio wiki.
- [] Basic feature docs are published on preliminary.istio.io describing what the feature does, how to use it, and any caveats.
- [] Release notes entries added as appropriate
- [] Upgrade notes entries added as appropriate
- [ ] Reference docs are published to preliminary.istio.io or the Istio wiki.
- [ ] Basic feature docs are published on preliminary.istio.io describing what the feature does, how to use it, and any caveats.
- [ ] Release notes entries added as appropriate
- [ ] Upgrade notes entries added as appropriate

Comment on lines +125 to +126
- [] Automated integration tests cover core use cases with the feature enabled.
- [] When disabled, the feature does not affect system stability or performance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [] Automated integration tests cover core use cases with the feature enabled.
- [] When disabled, the feature does not affect system stability or performance.
- [ ] Automated integration tests cover core use cases with the feature enabled.
- [ ] When disabled, the feature does not affect system stability or performance.

Comment on lines +134 to +136
- [] The appropriate work group(s) have reviewed and approved promotion of the feature.
- [] The TOC has reviewed and approved promotion of the feature as part of the
roadmap for a release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [] The appropriate work group(s) have reviewed and approved promotion of the feature.
- [] The TOC has reviewed and approved promotion of the feature as part of the
roadmap for a release.
- [ ] The appropriate work group(s) have reviewed and approved promotion of the feature.
- [ ] The TOC has reviewed and approved promotion of the feature as part of the roadmap for a release.


[//]: # (The feature implementation section must be completed before submission of the document.)

# Feature:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Feature:
# Features


## Experimental

### Requirements:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Requirements:
### Requirements

Comment on lines +91 to +93
- [X] Disabled by default.

- [X] No impact on performance when the feature is disabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [X] Disabled by default.
- [X] No impact on performance when the feature is disabled.
- [X] Disabled by default.
- [X] No impact on performance when the feature is disabled.


## Beta

### Requirements:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Requirements:
### Requirements


## Stable

### Requirements:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Requirements:
### Requirements

@istio-testing
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Experimental] Custom CA Integration using Kubernetes CSR needs to be added to feature status
5 participants