-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report printing refactor #7074
Report printing refactor #7074
Conversation
- Revert filters field behaviour
- Greatly simplify filtering logic compared to existing implemetation - Expose to API schema
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looks promising! I am still convinced that reports and labels should be the same thing but we have to start somewhere. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7074 +/- ##
==========================================
- Coverage 84.07% 83.21% -0.87%
==========================================
Files 1056 1069 +13
Lines 46440 46854 +414
Branches 1334 1376 +42
==========================================
- Hits 39046 38989 -57
- Misses 7055 7508 +453
- Partials 339 357 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Labels get printed against LabelTemplate items, duh
- Re-initialize field options if not already set
Should we maybe open a follow up issue with all the future ideas for this area that were voiced here? |
Yes I think that's a great idea |
This PR presents a major refactoring of how we handle report templates. In particular, a lot of model duplication and API endpoint duplication is removed. This is a precursor to supporting reports in the new interface, and potentially expanding the functionality of the reporting framework into the future.
Note that this is a breaking change as we are removing a number of models, and also deleting a number of existing API endpoints
Related Issues
Features / Updates
ReportTemplate
database modelTODO
generate_filename
method - ensure it works for reports and labelsreport.mixins