!usbd:dwc_otg:OUT prematured urb RXC leads to loose next URB #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… standalone OUT_COMP received packet, that rise RXC IRQ
this RCX will captureb by next active URB, and leads to terminate it.
|
Ok, this PR seem to fix a bug. |
| @@ -919,6 +921,18 @@ static void process_out_endpoint_interrupt(usbd_device *dev, uint8_t ep_num) | |||
| LOGF_LN("Transfer Complete: endpoint 0x%"PRIx8, ep_addr); | |||
| usbd_urb *urb = usbd_find_active_urb(dev, ep_addr); | |||
|
|
|||
| if (is_ep_prematured(dev, ep_addr)) { | |||
| if (urb != NULL){ | |||
| //* ommit this RXC and restart current URB | |||
There was a problem hiding this comment.
Note: "//" C++ comments. Please use C style: /* */
There was a problem hiding this comment.
I suggest you add the -ansi -pedantic options to gcc to have it warn on these.
There was a problem hiding this comment.
C style comments less then 5lines - disturbing me, especialy if it goes in a distance of 1-10lines of code
…eted by URB submit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on stm32 premature completed URBs (finished by short packet or else) are followed by standalone OUT_COMP received packet, that rise RXC IRQ.
this RCX will captured by next active URB, and leads to terminate it.
this patch tests against MSD implementation - it allow format usb drive in winXP.