USBD dwc_otg register bits fixed for FIFO flush #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ CGINAK !usbd:flush_fifo - now unsures core not access to fifo before flush - according to stm32f4 RM0090 notes.
kuldeepdhaka
reviewed
Mar 9, 2017
| @@ -0,0 +1,1692 @@ | |||
| /* | |||
There was a problem hiding this comment.
this file is auto generated.
not to be included in git history
There was a problem hiding this comment.
it was intruded by mistake from my branch
kuldeepdhaka
reviewed
Mar 9, 2017
| @@ -99,7 +99,7 @@ bit AHBIDL 31 | |||
| bits | |||
| name TXFNUM | |||
| size 5 | |||
| offset 16 | |||
| offset 6 | |||
kuldeepdhaka
reviewed
Mar 9, 2017
| @@ -495,7 +495,8 @@ reg DCTL 0x804 | |||
| bit POPRGDNE 11 | |||
| bit CGONAK 10 | |||
| bit SGONAK 9 | |||
| bit SGINAK 8 | |||
| bit CGINAK 8 | |||
kuldeepdhaka
reviewed
Mar 9, 2017
lib/usbd/backend/usbd_dwc_otg.c
Outdated
| @@ -109,12 +109,25 @@ static inline uint16_t get_fifo_depth(usbd_device *dev) | |||
| */ | |||
| static void flush_fifo(usbd_device *dev) | |||
| { | |||
| // Set Global IN OUT ep NACK | |||
There was a problem hiding this comment.
C code. "//" is c++ comment style.
There was a problem hiding this comment.
i also would like to point out https://github.com/insane-adding-machines/unicore-mx/blob/master/HACKING
it is a useful resource for stuff like coding style we accept.
kuldeepdhaka
reviewed
Mar 9, 2017
lib/usbd/backend/usbd_dwc_otg.c
Outdated
|
|
||
| const uint32_t GNACKEFF = DWC_OTG_GINTMSK_GINAKEFFM ; // | DWC_OTG_GINTMSK_GONAKEFFM ; | ||
| // Wait Global NACK Effective | ||
| while ( (REBASE(DWC_OTG_GINTSTS) & GNACKEFF) != GNACKEFF ); |
There was a problem hiding this comment.
while ((REBASE(DWC_OTG_GINTSTS) & GNACKEFF) != GNACKEFF); extra space.
codebase i see dont have any such space after bracket open or close. we can just stick to it.
…status, waiting for them can hang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some USBD register fields was broken or miss.
also fifo flush routine now more strict prepares for flushing