Usbd MSC windows minimum scsi implementation #47
Conversation
* usbd_private.h:USBD_LOGxxx(verbose_level - migrate to new debug printer style + USB_Vxxx - denotes verbosity levels + USB_VCALL,VIO,VSETUP - denotes code sections to log * usbd_log_call - deploy USBD_LOG_CALL to standalone printer routine * usbd_dwc_otg - starts migrate to new logstyle
+ USB_VURB,VURBQUE,VURBFAIL,VIO_MSC
…LBA adress + usbd_msc_blocks - extraxt this method for future backend changes
…by windows msc driver + msc_scsi.h - extrat scsi api to alone header +usb/byteorder.h - provide hton/ntoh convertions for scsi api
+ USB_VIO2
…and <read format capacity> on windows. +usbd:msc:usbd_msc_backend:inquiry_page - introduce INQUIRY into msc backend. + unit_blocks_count - introduce api for media size in backend + usbd_scsi_inquiry_(page|standart_page) - publish default implementations of inquiry for external override + usbd_scsi_inquiry_evpd_(supports|serial) - publish default page composers for external override
| @@ -92,6 +92,8 @@ struct sbc_sense_info { | |||
| uint8_t ascq; | |||
| }; | |||
|
|
|||
|
|
|||
| #define USBD_MSC_SEC_SIZE 512 | |||
| @@ -64,15 +64,17 @@ typedef struct usbd_msc_backend usbd_msc_backend; | |||
| * @param lock Lock. Optional - can be NULL | |||
| * @param unlock Unlock. Optional - can be NULL | |||
| */ | |||
| typedef uint32_t msc_lba_t; | |||
There was a problem hiding this comment.
Look ok to me but,
Tab between "uint32_t" "msc_lba_t;"
(Not nitpicking) but a space is sufficient.
In other part of the code (was a typedef), you use a space instead.
Please read more code of the project and maintain the same pattern/code style.
| } scsi_periferial_qualify; | ||
|
|
||
| typedef enum { | ||
| , scsi_dtDirectBlock = 0 //* < Direct access block device (e.g., magnetic disk) |
There was a problem hiding this comment.
- C Comment
- "," before enum decl
- enum are expected to be uppercase
| set_sbc_status_good(ms); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
What are you trying to do with the new code.
please explain the purpose.
a comment or commit msg should be ok.
There was a problem hiding this comment.
the name of routine scsi_read_format_capacities - not enough? this is standart scsi request. win demand it from usb msd.
| { | ||
| if (EVENT_CBW_VALID == event) { | ||
| usb_msc_rfc_capacity_list_header* h = (usb_msc_rfc_capacity_list_header*)trans->msd_buf; | ||
| usb_msc_rfc_capacity_descriptor* descr = (usb_msc_rfc_capacity_descriptor*) (trans->msd_buf+sizeof(*h)); |
There was a problem hiding this comment.
"trans->msd_buf+sizeof(*h)" space before & after "+".
| enum trans_event event) | ||
| { | ||
| if (EVENT_CBW_VALID == event) { | ||
| usb_msc_rfc_capacity_list_header* h = (usb_msc_rfc_capacity_list_header*)trans->msd_buf; |
There was a problem hiding this comment.
"(usb_msc_rfc_capacity_list_header*)trans->msd_buf" space after "*)"
|
Note to myself:
|
| LGPL License Terms @ref lgpl_license | ||
| */ | ||
| /* | ||
| * Copyright (C) 2016 alexrayne <[email protected]> |
There was a problem hiding this comment.
Minor note: INAL, as of my understanding of copyright.
copyright name/year/email for Weston Schmidt and/or Pavol Rusnak need to be added because they authored the file from which some of the content you moved.
here provided MSC scsi , commands that denamded by win8
also introduced API that allow overriding by user code.
this branch also includes USBD logging refactorings to USBD_LOGXXX macros, vs old simple LOGXXX.
also level of log verbosity defined by value of USBD_DEBUG. levels system and loging sections are declared in usbd_private.h