!uc-def:lines - remove usage of file.tell() - this is buggy on windows #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.(i guess it 1byte ovehead on each line.).
now read whole file and split to lines at once. it is risky for memory, but we not intends use infinite definitions.
! :unsigned longs - now bit-masks are use 'ul' suffix if it is larger 16bit. it away some compile warnings about
integers arith overload, and integer sign chages
| @@ -47,10 +47,19 @@ def verify_access_flags(data): | |||
| raise Exception("'%c' flag of flags '%s' not valid" % (i, data)) | |||
|
|
|||
| def next_useful_line(tag, strip_newline=True, strip_comment=True): | |||
| if not ('input_lines' in tag): | |||
| tag['input_lines'] = tag['input_file'].readlines() | |||
There was a problem hiding this comment.
If we can parse the file in stream style, why would we go for read the whole content to memory file.
file.tell() - this is buggy on windows any pointer on the specific problem?
also, i guess it 1byte ovehead on each line. if we talk of overhead, we should convert the script in C program.
There was a problem hiding this comment.
i dont want spend my time making bugreport and testsuit to python.
short: on my winXP git has checkoput .ucf with linux \n lienends. looks like python string engine converts somehow internaly to windows \r\n lineneds. therefore tell() counts 1 more byte per string. after 20 strings tell() position points after actual string begin about 20bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on windows file.tell() ,i guess, makes 1byte ovehead on each line. therefore reposition to line begin is broken.
now read whole file and split to lines at once. it is risky for memory, but we not intends use infinite definitions.
! :unsigned longs - now bit-masks are use 'ul' suffix if it is larger 16bit. it away some compile warnings about integers arith overload, and integer sign chages