Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed fixes for ec2 provider create with non-default VPC. Closes #… #75

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Proposed fixes for ec2 provider create with non-default VPC. Closes #… #75

merged 1 commit into from
Aug 24, 2020

Commits on Aug 11, 2020

  1. Various fixes for ec2 provider create command 

    The create command failed when a default VPC was not
present for the ec2 provider. When the failure occurred there
was also a side effect of dangling security groups that
got created but not cleaned up in the event of failure.

Two additional arguments were added, vpc-id and subnet-id,
to mitigate the failure while also giving users the option
to choose a specific VPC and subnet if more than one VPC
exists. New validation checks that if one of these new arguments
are specified then the other must be as well.

Additional logic was added so that in the event of ec2
instance creation failure any security groups created
will get deleted.

Signed-off-by: Shane Witbeck <[email protected]>
    @thesurlydev
    thesurlydev committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8729851 View commit details
    Browse the repository at this point in the history