Remove activate scene in automation editor

[silamon]

Proposed change

Some services have "overrides" in the frontend presenting a different layout. Activate scene is one of them.
I'm removing this so the service definition provided by the backend is used, as it provides more options.
Options that do already appear if you transition from visual to yaml to visual.

There's also a legacy scene action, I don't know what it is and how long it is legacy.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[j4n-e4t]

Hi @silamon,
I see why you would remove the action. It is in fact a duplicate with less functionality.

I'm just not sure if this makes the UX worse since a user then can't search for "Scene" anymore to activate it. For other device types, this works better. (e.g. light. A light is a device, so a user can search for device.) A scene however is a thing of itself and I don't think it's intuitive to only have it in the Action block but I could be wrong.

[silamon]

Hi @silamon, I see why you would remove the action. It is in fact a duplicate with less functionality.

I'm just not sure if this makes the UX worse since a user then can't search for "Scene" anymore to activate it. For other device types, this works better. (e.g. light. A light is a device, so a user can search for device.) A scene however is a thing of itself and I don't think it's intuitive to only have it in the Action block but I could be wrong.

I don't think I'm getting exactly what you're trying to say. You can use the action "Scenes: Activate", then select a scene of choice in the target picker.

[j4n-e4t]

Hi @silamon, I see why you would remove the action. It is in fact a duplicate with less functionality.
I'm just not sure if this makes the UX worse since a user then can't search for "Scene" anymore to activate it. For other device types, this works better. (e.g. light. A light is a device, so a user can search for device.) A scene however is a thing of itself and I don't think it's intuitive to only have it in the Action block but I could be wrong.

I don't think I'm getting exactly what you're trying to say. You can use the action "Scenes: Activate", then select a scene of choice in the target picker.

@silamon Yes, you're right. My fault. For some reason, this action didn't show up in my environment until now. 😔
Should have look into that more. That's said, I actually think it's a good idea to remove the action to streamline the UX.

[silamon]

We still need to resolve the unknown legacy action, what it is for and if it should be kept, before merging.

[MindFreeze]

We still need to resolve the unknown legacy action, what it is for and if it should be kept, before merging.

Just tested what would happen if someone has a legacy action that is just scene: some_scene. The UI for the action just reverts to YAML. I think this is acceptable.
The title of the action block is still handled since this isn't removed in this PR. The check is here

frontend/src/data/script.ts

Line 383 in 7734922

if ("scene" in action) {

If this is also removed, it will say "Unknown" in the title