-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for new Lutron color tuning device, Supported via https://github.com/gurumitts/pylutron-caseta/pull/177 #130731
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RBaragona
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @swails, @danaues, @eclair4151, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -92,6 +98,8 @@ def __init__(self, light: dict[str, Any], data: LutronCasetaData) -> None: | |||
self.supports_warm_cool = light_type in WARM_DEVICE_TYPES | |||
self.supports_warm_dim = light_type == DEVICE_TYPE_SPECTRUM_TUNE | |||
self.supports_spectrum_tune = light_type == DEVICE_TYPE_SPECTRUM_TUNE | |||
self.supports_warm_dim = light_type == DEVICE_TYPE_COLOR_TUNE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't these overwrite the lines above it? Ie if the light is spectrum tune the variables are set to true in the lines above this, then set back to false here because it is not a color_tune
Also to confirm, you'll need to wait until your pylutron-caseta PR Is merged, then raise 2 PRs here, the first just bumping the Python library version, and this is the second PR which can be merged after the first is merged. |
Proposed change
Add support for new device type in Lutron-Caseta to enable support of new color and tunable white products.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: