feat: thrift-gen-rpc-swagger plugin #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZ4Jam1n
changed the title
Skyenought
reviewed
Aug 22, 2024
| return err | ||
| } | ||
|
|
||
| if req == nil { |
Skyenought
reviewed
Aug 22, 2024
| d.Info = &openapi.Info{ | ||
| Title: "API generated by thrift-gen-rpc-swagger", | ||
| Description: "API description", | ||
| Version: "1.0.0", |
Skyenought
reviewed
Aug 22, 2024
| v := s.Annotations.Get(OpenapiDocument) | ||
| if len(v) > 0 { | ||
| ret = s.GetName() | ||
| return "service", ret |
Skyenought
reviewed
Aug 22, 2024
|
|
||
| fieldSchema := &openapi.SchemaOrReference{ | ||
| Schema: &openapi.Schema{ | ||
| Type: "object", |
There was a problem hiding this comment.
我觉得这种类似的 string, 都换成 const 比较好
|
其他的 repo 我没有看，可能也有类似的小问题。你先解决一个后续统一一下吧 |
|
cc @EZ4Jam1n |
li-jin-gou
reviewed
Sep 5, 2024
| @@ -50,15 +50,16 @@ func Run() int { | |||
| } | |||
|
|
|||
| func handleRequest(req *plugin.Request) (err error) { | |||
| if req == nil { | |||
| fmt.Fprintf(os.Stderr, "unexpected nil request") | |||
li-jin-gou
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
thrift-gen-rpc-swagger 插件
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: