Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #113

wants to merge 1 commit into from

Conversation

Gabrail
Copy link

@Gabrail Gabrail commented Dec 24, 2024

remove the added config for LOVE_ENDPOINT under front section, also mention to add the LIVEKIT_WS with WSS prefix

remove the added config for LOVE_ENDPOINT under front section, also mention to add the LIVEKIT_WS with WSS prefix

Signed-off-by: Mo Gabrail <[email protected]>
@sh4hzaib
Copy link

sh4hzaib commented Jan 16, 2025

I want to mention couple of things in section "Love Service (Audio & Video calls)"

  • on step 2, the image section should be like

    "image: hardcoreeng/love:${HULY_VERSION}"
    this should make sure consistent version.

  • secret should be picked from huly.conf
    "SECRET=${SECRET}"

At first glance, I thought secret is something like a secret variable, that might be used for any encryption and generated separately. It took a while to go through other issues and code to observe what really should be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants