Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of issensitive must return unknown for unknown args without sensitive into v1.10 #36014

Merged

Conversation

github-actions[bot]
Copy link

Backport

This PR is auto-generated from #36012 to be assessed for backporting due to the inclusion of the label 1.10-backport.

The below text is copied from the body of the original PR.


Terraform attempts to track marks as accurately as possible, but unknown values may not always have the same marks as they will when they become known. This is most easily seen with functions, which are allowed to return an unknown value when faced with any unknown arguments, while they are also allowed to manipulate the marks on the values as they see fit. This results in situations where the marks simply cannot be known.

Terraform generally takes the stance that if an unknown has a mark, it will remain in the final value, but the absence of a mark is not indicative of the absence of any marks in the final value. That appears to be something we can continue to maintain throughout the codebase, so given that axiom I'm going to codify it here by only changing the issensitive results for unknown, unmarked values, but allowing unknown+sensitive values to return true.


Overview of commits

@github-actions github-actions bot force-pushed the backport/jbardin/issensitive-unknown/ghastly-sweet-woodcock branch from 5967ad9 to a1ed241 Compare November 15, 2024 16:19
@jbardin jbardin marked this pull request as ready for review November 15, 2024 16:20
@jbardin jbardin merged commit a630e91 into v1.10 Nov 15, 2024
5 of 6 checks passed
@jbardin jbardin deleted the backport/jbardin/issensitive-unknown/ghastly-sweet-woodcock branch November 15, 2024 16:27
Copy link
Author

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant