Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bring default valuesContext when customizing vm-import-controller addon #1267

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: bring default valuesContext when customizing vm-import-controller addon #1267

merged 1 commit into from
Jan 16, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 15, 2025 •
edited
Loading

Summary

fix: bring default this.value.spec.valuesContext when customizing vm-import controller

valuesContent: |
    image:
      tag: v0.4.1
    fullnameOverride: harvester-vm-import-controller

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#7351 (comment)

Occurred changes and/or fixed issues

Will port to harvester-ui-extension once this PR merged.

Areas which could experience regressions

Screenshot/Video

fix_vm_import.mov

@a110605 a110605 self-assigned this Jan 15, 2025
@a110605 a110605 changed the title fix: bring default valueContext when customizing vm-import controller fix: bring default valueContext when customizing vm-import-controller addon Jan 15, 2025
@a110605 a110605 changed the title fix: bring default valueContext when customizing vm-import-controller addon fix: bring default valuesContext when customizing vm-import-controller addon Jan 15, 2025
@a110605
Copy link
Collaborator Author

a110605 commented Jan 15, 2025 •
edited
Loading

@ibrokethecloud , could you help confirm the valuesContext is expected ? thx

torchiaf
torchiaf approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/harvester/edit/harvesterhci.io.addon/vm-import-controller.vue Show resolved Hide resolved
ibrokethecloud
ibrokethecloud approved these changes Jan 15, 2025
View reviewed changes
Copy link

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. can confirm that valueContent is merged as expected.

@a110605 a110605 merged commit b78181d into harvester:master Jan 16, 2025
11 checks passed
@mergify mergify bot mentioned this pull request Jan 16, 2025
Merged
3 tasks
@a110605 a110605 mentioned this pull request Jan 16, 2025
Merged
2 tasks
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torchiaf torchiaf torchiaf approved these changes

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

@houhoucoop houhoucoop Awaiting requested review from houhoucoop

Assignees

@a110605 a110605

Labels
Require backport v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @ibrokethecloud @torchiaf