-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snowMelt-elijahPierce #968
base: main
Are you sure you want to change the base?
Conversation
@anomynous1225 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Hello! Sorry it's been so long. The main reviewer has been swamped lately, so I wanted to give you a few hints so you have the best chance of getting a blot. Would you be able to rename your project file to index.js? That would make it so that the automation to generate a preview can run, which is super nice for reviewers! In terms of the actual project, I really like it! I think you're suuuper close to getting a blot, there are just a few things I would add / change and then you'll be there! For the specific pictures, I mostly just would love to see a bit more randomness. Anyway, I don't think you'll have to do so much per image, but just like one or two more randomization bits would get it that last little bit of the way. You're super close to getting a blot! I'm excited to see the final changes! |
|
I have gone in and made some changes if there’s anything else is anything else to do please let me knowSent from my iPhoneOn Nov 13, 2024, at 9:24 PM, github-actions[bot] ***@***.***> wrote:
art/snowMelt-elijahPierce/index.js looks like art! preview it in the editor
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hello! Thanks! |
It’s under the same code I just copied and pasted my new edits thereSent from my iPhoneOn Nov 13, 2024, at 9:44 PM, EnterpriseGoose ***@***.***> wrote:
Hello!
I'm getting the preview link now but it doesn't seem like the changes got pushed. Can you check that the code was updated?
Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I don't really understand what you mean by that- the code currently in this
push does not contain the clouds or suns. Maybe could you try just
repasting the edits into your fork and see if that works? As soon as you
do, I'll forward this off to the main reviewer.
|
added cloud and sun and stuff
Ok I went in it has it 100% now last time I think I pressed ctr z not ctr vSent from my iPhoneOn Nov 14, 2024, at 7:25 AM, EnterpriseGoose ***@***.***> wrote:
I don't really understand what you mean by that- the code currently in this
push does not contain the clouds or suns. Maybe could you try just
repasting the edits into your fork and see if that works? As soon as you
do, I'll forward this off to the main reviewer.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I have 6 different pictures displayed randomly one of which is played half the time and the other 5 are played 1/10 of the time one picture is of a snowman an igloo and a penguin the penguin and the snowman s noses are randomized in size the snowman s hat is randomized in size and there is "snow" which is randomly placed on the canvas. One picture is of the same penguin with X instead of eyes and you can see the snowman s hat as if it melted there is the sun in this picture. Another picture is of a canoe in rough water with lightning randomly hitting the boat. Another picture is of an iceberg glacier floating on the water with snow. another picture is of the canoe hitting the iceberg. The last picture is of a volcanoe with a asteroid randomly landing on the top of the screen.
Math.random()
(See the documentation on randomness)If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here:
Lastly, link a picture of your art piece here: