-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Circle Generation for HeartOfCircles to Stay Within Drawable Bounds (Follow-up to PR #823) #946
base: main
Are you sure you want to change the base?
Conversation
@PawiX25 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
@EnterpriseGoose I've made the updates requested in the review! |
Just took a look at it again and it's looking great! I think it's almost there. Just a couple things I noticed:
Once you address these, I'll send it to Alex (the official reviewer) to see what he thinks. |
This is an updated version of my "HeartOfCircles" art piece, where I have now fixed the circle generation to ensure it stays within drawable bounds. The artwork represents a blend of geometric shapes and harmonious heart patterns, drawn from algorithmic creativity. My experience creating it was both challenging and rewarding, especially while tweaking the shapes.
Checklist
Math.random()
Additional Info
This PR is an update to the original PR #823, where I was asked to fix the circle generation to stay within the drawable bounds. That issue has been addressed.
Image