New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow friendlier tag names #3304

Open

Aceix wants to merge 1 commit into develop from kwesi/net-1909-validation-on-tag-names

Contributor

Aceix commented Jan 16, 2025

update tag name validation to allow spaces and numbers

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

My changes affect only 10 files or less.
I have performed a self-review of my code and tested it.
If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
If it is a bugfix, my code is <= 200 lines.
My functions are <= 80 lines.
I have had my code reviewed by a peer.
My unit tests pass locally.
Netmaker is awesome.


          refactor: allow friendlier tag names

6bfd46c

- update tag name validation to allow spaces and numbers

Aceix requested a review from abhishek9686

January 16, 2025 10:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet