helm: Move non-CRDs resources to proper helm templates #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2023 20:43
…lates To preserve the same sort of behavior, leveraging helm hooks instead. Having non-CRDs resources in the crds/ folder isn't exactly forbidden by Helm, but it breaks some assumptions and leads to interesting side-effects. For instance FluxCD's helm-controller fails when encountering namespaces resources in the crds/ folder Aditionally, this makes it possible to use template rendering for all these non-CRD jobs and resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move non-CRDs out of the crds/ folder and into proper helm templates
To preserve the same sort of behavior, leveraging helm hooks instead.
Having non-CRDs resources in the crds/ folder isn't exactly forbidden by Helm, but it breaks some assumptions and leads to interesting side-effects.
For instance FluxCD's helm-controller fails when encountering namespaces resources in the crds/ folder
Aditionally, this makes it possible to use template rendering for all these non-CRD jobs and resources