Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark for async list with nested async field #3805

Closed
wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

@netlify
Copy link

netlify bot commented Dec 27, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit af60b5f
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/66fbd01e6bcd420008dc31ea
😎 Deploy Preview https://deploy-preview-3805--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yaacovCR yaacovCR requested a review from a team December 27, 2022 11:40
@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

Results on my PC comparing latest to prior to #3754

image

The performance benefit of #3754 can almost disappear with the addition of nested fields. Filling out the benchmark suite a little more may help us better qualify where optimizations help (or potentially hurt).

@yaacovCR yaacovCR changed the title add additional benchmark add benchmark for async list with nested async field Dec 27, 2022
@yaacovCR

This comment has been minimized.

Copy link

github-actions bot commented Oct 1, 2024

@github-actions run-benchmark

@yaacovCR Something went wrong, please check log.

@yaacovCR
Copy link
Contributor Author

Closing this old PR for now. We can revisit once we have a new benchmark solution, see #4243 for latest suggestion.

@yaacovCR yaacovCR closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants