Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow service without authproxy #504

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

afreyermuth98
Copy link

I want to be able to access the service without using the authproxy.
Moreover I added the way to put some custom labels and annotations on it

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

Signed-off-by: afreyermuth98 <[email protected]>
Signed-off-by: afreyermuth98 <[email protected]>
Signed-off-by: afreyermuth98 <[email protected]>
@yorugac
Copy link
Collaborator

yorugac commented Dec 20, 2024

@afreyermuth98, thanks for the PR! We don't have an issue for this yet, so could you please describe more precisely the use cases you're facing?

FYI, there are rather large structural changes in manifests happening as part of #235, and authentication and metrics will be impacted as well. So this PR can be considered only after that work is done. Given the holidays, that'll probably be in the next year. Meanwhile, if you have the time to consider how your proposal will fit in into the new structure and updated manifests, I'd appreciate it greatly! (ref. PR: #512, also kubernetes-sigs/kubebuilder#3907)

@afreyermuth98
Copy link
Author

Hello @yorugac ! Thanks for this answer :)
My needs are pretty simple :
I have an otel collector that is scraping my pods / service depending on their annotations and I do not (want to) set auth-proxy on my k6-operator setup. But the service is created only if auth-proxy is enabled so it blocks me.
With my PR, I can force to have a service (with custom annotations) to get it scraped and collect the metrics without having to set the auth-proxy.
Do not hesitate to reach me again if it's not clear / if something is needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants