Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First enzyme tests #69

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

First enzyme tests #69

wants to merge 15 commits into from

Conversation

raakasf
Copy link
Collaborator

@raakasf raakasf commented Apr 23, 2021 •
edited
Loading

  • Added enzyme and jest related packages
  • Updated jest config to fake/remove css
  • Error Boundary (prevent crash when trying to edit existing variables)
  • Basic initialization Enzyme tests for
    • src/VariableQueryEditor.test.tsx
    • src/builder/query/Sql.test.tsx
    • src/configuration/ConnectionSettings/DruidAuthSettings.test.tsx
    • src/configuration/ConnectionSettings/DruidConnectionSettings.test.tsx

@raakasf raakasf self-assigned this Apr 23, 2021
@raakasf raakasf added the enhancement New feature or request label Apr 23, 2021
@raakasf raakasf requested a review from jbguerraz April 23, 2021 19:10
@jbguerraz
Copy link
Contributor

Thank you @raakasf !
Could you rebase on top of master (refactored version) and keep only the tests in that PR please ? thx!

jbguerraz
jbguerraz requested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@jbguerraz jbguerraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase atop master + keep tests only please

@jbguerraz jbguerraz force-pushed the master branch 3 times, most recently from 2e7e996 to cb3a684 Compare May 18, 2021 16:21
@jbguerraz jbguerraz force-pushed the master branch 3 times, most recently from de54843 to 2e92d79 Compare July 9, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbguerraz jbguerraz jbguerraz requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@raakasf raakasf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raakasf @jbguerraz