Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kadai3 sawadashota #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

kadai3 sawadashota #25

wants to merge 2 commits into from

Conversation

sawadashota
Copy link

@sawadashota sawadashota commented Jun 30, 2018

課題3を提出させていただきます。

タイピングゲームを作ろう

使い方等はこちらに記載
https://github.com/gopherdojo/dojo2/tree/1da3995cfbce50cf2767ecec8977a2d9a09cb660/kadai3-1/sawadashota

分割ダウンロードを行う

  • Rangeアクセスを用いる
  • いくつかのゴルーチンでダウンロードしてマージする
  • エラー処理を工夫する
    • golang.org/x/sync/errgourpパッケージなどを使ってみる
  • キャンセルが発生した場合の実装を行う
  • Testを書く

困っていること

引数に-p 1を渡して分割しないダウンロードのほうが速い結果になってしまってしまっています・・・

$ go run main.go -p 1 https://github.com/sawadashota/gocmd/archive/v1.0.11.tar.gz
Duration 2.152824 seconds

$ go run main.go -p 2 https://github.com/sawadashota/gocmd/archive/v1.0.11.tar.gz
Duration 3.355878 seconds

$ go run main.go  https://github.com/sawadashota/gocmd/archive/v1.0.11.tar.gz
Duration 4.182875 seconds

@sawadashota sawadashota self-assigned this Jun 30, 2018
@sawadashota sawadashota requested a review from tenntenn June 30, 2018 12:15
テストとキャンセル処理は未実装
@sawadashota sawadashota force-pushed the kadai3-sawadashota branch from be921af to a58bb0b Compare July 1, 2018 14:21
@tenntenn tenntenn added the kadai3 This issue or pull request already exists label Jul 5, 2018
@sawadashota sawadashota changed the title [WIP] kadai3 sawadashota kadai3 sawadashota Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kadai3 This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants