Split the is_importing stat in two #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhmn
force-pushed
the
elhmn-split-the-is-importing-stat
branch
2 times, most recently
from
2bfa3e4 to
6a33470
Compare
elhmn
force-pushed
the
elhmn-split-the-is-importing-stat
branch
from
6a33470 to
b720153
Compare
We want to use two new different sockstats, `import_skip_push_limit` and `import_soft_throttling` which are respectively used to allow a higher push limit, and implement soft throttling policy for imports. We still forward the `is_importing` stat for to skip push limit for backward compatibility. We plan to remove it on a subsequent PR.
elhmn
force-pushed
the
elhmn-split-the-is-importing-stat
branch
from
b720153 to
aeb2528
Compare
elhmn
changed the title
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
migue
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use two new different sockstats,
import_skip_push_limitandimport_soft_throttlingwhich are respectively used to allow a higher push limit, and implement soft throttling policy for imports.We still forward the
is_importingstat for to skip push limit for backward compatibility. We plan to remove it on a subsequent PR.