Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive DNS lookup with Dnsruby::Recursor #141

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Recursive DNS lookup with Dnsruby::Recursor #141

wants to merge 2 commits into from

Conversation

TooManyBees
Copy link
Contributor

@TooManyBees TooManyBees commented Jan 18, 2022 •
edited
Loading

GitHubPages::HealthCheck::Resolver does a recursive DNS lookup by wrapping Dnsruby::Resolver in a Dnsruby::Recursor. No change to its API.

addresses https://github.com/github/pages-engineering/issues/912

@TooManyBees
Copy link
Contributor Author

This PR increases the time that it takes to run the test suite. May want to consider mocking web requests.

In spec/github_pages_health_check/resolver_spec.rb, the test "uses an authoritative resolver" usually fails by raising Dnsruby::ResolvError::Refused when run in isolation. The test passes when run with other tests (so, when not run first). Keep this as a draft PR until we can figure that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TooManyBees