chore(deps-dev): bump markdownlint from 0.36.1 to 0.37.3 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [markdownlint](https://github.com/DavidAnson/markdownlint) from 0.36.1 to 0.37.3. - [Changelog](https://github.com/DavidAnson/markdownlint/blob/main/CHANGELOG.md) - [Commits](DavidAnson/markdownlint@v0.36.1...v0.37.3) --- updated-dependencies: - dependency-name: markdownlint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
JoyceZhu
reviewed
Jan 10, 2025
index.js
Outdated
| return foo; | ||
| } | ||
|
|
||
| // export default githubMarkdownLint; |
There was a problem hiding this comment.
can't seem to export destructures in ESM, static vs dynamic?
JoyceZhu
reviewed
Jan 10, 2025
JoyceZhu
reviewed
Jan 10, 2025
| @@ -1,19 +1,20 @@ | |||
| const _ = require("lodash"); | |||
| import _ from "lodash-es"; | |||
There was a problem hiding this comment.
regular lodash is synchronous
JoyceZhu
reviewed
Jan 10, 2025
package.json
Outdated
| "directories": { | ||
| "test": "test" | ||
| }, | ||
| "scripts": { | ||
| "publish": "npm publish --access public --@github:registry=https://registry.npmjs.org", | ||
| "test": "npm run lint && jest", | ||
| "test": "NODE_OPTIONS=--experimental-vm-modules jest", |
There was a problem hiding this comment.
jest needs this to enable ESM
JoyceZhu
reviewed
Jan 10, 2025
package.json
Outdated
| "markdownlint": "^0.36.1", | ||
| "markdownlint-cli2": "^0.16.0" | ||
| "markdownlint": "^0.37.3", | ||
| "markdownlint-cli2": "^0.17.0" |
There was a problem hiding this comment.
cli2 previous version seemed incompatible w/new markdownlint
JoyceZhu
reviewed
Jan 10, 2025
JoyceZhu
reviewed
Jan 10, 2025
| @@ -1,6 +1,6 @@ | |||
| const markdownlint = require("markdownlint"); | |||
| import { lint } from "markdownlint/async"; | |||
|
@JoyceZhu should I remove this from the FR queue until you're ready for a review? Or is there anything I can do to assist? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included (from @JoyceZhu):
READMEto use ESM syntax/examplespackage.jsonchanges for ESMeslintconfig changes to respect that ESM imports need to reference the file extension in the path without further worklodash-essince the originallodashlibrary is CommonJS-onlymarkdownlint-cli2calls to newasyncimplementations.nvmrcsince I was already hereJSONfiles -- convert those to manual file readsBumps markdownlint from 0.36.1 to 0.37.3.
Changelog
Sourced from markdownlint's changelog.
Commits
74b1c19Update to version 0.37.3.ef70472Make micromark-core-commonmark a direct dependency to satisfy strict dependen...795eac2Add CI job that verifies tests pass when using pnpm (vs. npm).df33933Update export test to avoid "ExperimentalWarning: Importing JSON modules is a...8e5f699Bump webpack-cli from 6.0.0 to 6.0.192eb425Bump eslint-plugin-n from 17.15.0 to 17.15.11587927Bump webpack-cli from 5.1.4 to 6.0.0a1081ecAdd "bundler" and "subpath" to dictionary.txt.5fad452Update to version 0.37.2.baf4944Add subpath imports "markdownlint-imports-browser" and "markdownlint-imports-...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)