-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trust-policies chart with support for trust domain #59
Conversation
Signed-off-by: Cody Soyland <[email protected]>
Signed-off-by: Cody Soyland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Cody Soyland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor non-blocking Q's, LGTM!
# githubTrustDomain may be set to the trust domain applicable for some GitHub Enterprise Cloud accounts. | ||
# If applicable, this may be set to the output of the following command: | ||
# $ gh api meta | jq .domains.artifact_attestations.trust_domain | ||
# See documentation for more details: https://docs.github.com/en/actions/security-for-github-actions/using-artifact-attestations/enforcing-artifact-attestations-with-a-kubernetes-admission-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I don't see any mention of trust domains on this documentation today - maybe it's getting updated later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steiza separate PR
@@ -8,8 +8,8 @@ sources: | |||
type: application | |||
|
|||
name: trust-policies | |||
version: "v0.5.0" | |||
appVersion: "v0.5.0" | |||
version: "v0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor / just to make sure I understand: we're making this tag after this pull request lands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right!
Signed-off-by: Cody Soyland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setting that keeps dismissing reviews is quite annoying...
Fixes https://github.com/github/package-security/issues/2105
Signed-off-by: Cody Soyland [email protected]