vulkan: change an assertion #10328
Open
vulkan: change an assertion #10328
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src1 can go down the first pipeline as nullptr and src0 only needs to be checked once this means the assertion is only required to check if the type is GGML_TYPE_F16 and can usually be skipped
FirstTimeEZ
commented
Nov 16, 2024
Comment on lines
+3936
to
+3939
| else { | ||
| GGML_ASSERT(src1->type == GGML_TYPE_F16); | ||
| return ctx->device->pipeline_soft_max_f32_f16; | ||
| } |
There was a problem hiding this comment.
else if (src1->type == GGML_TYPE_F16) {
return ctx->device->pipeline_soft_max_f32_f16;
}This could be else if with no assertion because it will return nullptr and fatal error anyway but maybe you want it to fail via the assertion.
|
Also gets rid of this, which is just caused by intellisense not being aware of the behavior of the assert macro (I think)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src1can go down the first pipeline asnullptrsrc0anddstonly need to be checked oncethe only thing that needs to be asserted here is if the type is
GGML_TYPE_F16but read my comment about that.