Draft: Allow running tests against installed rgbds #1621
Conversation
…nstalled binaries
Rangi42
added
tests
test/asm/test.sh
Outdated
There was a problem hiding this comment.
I often run the test.sh scripts individually; it would be nice if this defaulted to ../../ if not provided (I guess you would now have to do RGBDS=path/ ./test.sh?)
There was a problem hiding this comment.
It does default to ../../. That behavior only changes when --use-system-binaries is used.
There was a problem hiding this comment.
No, the test.sh scripts now default to the installed RGBDS:
That should be an opt-in feature just for Debian.
There was a problem hiding this comment.
Ah, I see my mistake now. The default comes from run-tests.sh, so it's missing for the individual files.
How would you propose I implement the default in the individual files?
Would passing the commandline argument (--installed-rgbds) into them be satisfactory?
There was a problem hiding this comment.
Yes, I think it should be kept simple.
RGBDS=../../
if [[ $# -eq 1 ]]; then
RGBDS="$1"
fiThere was a problem hiding this comment.
That won't quite work (the PATH version means we don't set RGBDS to anything), but I've got an idea in mind.
There was a problem hiding this comment.
Done, should work now
There was a problem hiding this comment.
Half the CI fails for some reason (Windows, MinGW, Cygwin, and macOS static)...
There was a problem hiding this comment.
I'm looking into it but would appreciate some help..
There was a problem hiding this comment.
I think it's because the failing CIs do not install RGBDS, they only copy the .exes.
There was a problem hiding this comment.
I think this is the reason, maybe some kind of "alias=" for those systems can make those binaries appear as the installed ones ? Or adding those to the path
Closes #1612
The two rgbgfx-related programs still use hardcoded paths and are thus broken. Working on that.
I'd appreciate some input on the naming of the commandline parameter (currently
--use-system-binaries).