-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #2 Page Responsiveness #94
base: master
Are you sure you want to change the base?
Conversation
I've tackled the resolution problem for iPad and iPad Pro, specifically honing in on the dimensions 1024x1366 and 768x1024 with focuss mainly bootstrap.min.css file. |
Please give a succint title for pull request, 3 lines is too much. At "Fix #number", please put the ID of the issue, not the ID of this pull request. |
"Thank you, thank you so much for your valuable feedback. I've changed the
title to 'Fix #2 Page Responsiveness'. I hope this name is suitable for
this repository. If not, please provide feedback on how to change it. I
understand you have a busy schedule, but I'm excited to contribute to this
project. I'm exited to solve another issue, and I appreciate the support
and feedback from our team."
…On Mon, 26 Feb 2024, 2:23 pm Nguyễn Hồng Quân, ***@***.***> wrote:
Please give a succint title for pull request, 3 lines is too much.
At "Fix #number", please put the ID of the issue, not the ID of this pull
request.
—
Reply to this email directly, view it on GitHub
<#94 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BENAFTG4B2KMVMMM5AWOKXDYVREQRAVCNFSM6AAAAABDIJGAEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGYYDINJVGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I've updated the link to point directly to the issue now. Please check it
out. I hope this fixes it.
…On Wed, 28 Feb 2024, 1:30 pm Nguyễn Hồng Quân, ***@***.***> wrote:
image.png (view on web)
<https://github.com/fossasia/summit.fossasia.org/assets/314607/f183a9e6-69f7-470b-9788-8f343bdd4a2b>
You still don't fix it. This link should point to the issue, not to this
very PR.
—
Reply to this email directly, view it on GitHub
<#94 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BENAFTDRZJV7DCALQUOMG63YV3P2HAVCNFSM6AAAAABDIJGAEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGQZDKMRWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Changes done in this Pull Request
Description / Changes
#2 iPad and iPad Pro Resolution Fix for Page Responsiveness
Description: This GitHub repository addresses the issue of page responsiveness on iPad and iPad Pro devices, with a specific focus on resolutions of 1024x1366 and 768x1024. The identified problem, labeled as Issue #2, highlighted inconsistencies in page display on these devices. As a first-time contributor, I took the initiative to investigate and resolve this issue, aiming for a 100% fix.
My approach involved thorough testing and debugging to ensure compatibility across different devices and screen sizes. After implementing the solution, I personally verified its effectiveness by checking the website on affected devices. I am confident that the resolution I provided effectively tackles the problem and enhances user experience on iPads and iPad Pros.
I believe this contribution will be valuable to the FOSSASIA group and its contributors. I eagerly await feedback from maintainers and fellow contributors, welcoming suggestions for further improvements. Your input will help refine this solution and contribute to the overall enhancement of the project.
Screenshots if any:
Before:
After: