Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resized #1069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resized #1069

wants to merge 1 commit into from

Conversation

samyakbvs
Copy link
Contributor

@samyakbvs samyakbvs commented Dec 5, 2019

  • Read and understood see CONTRIBUTING.md
  • Included a preview link and screenshot showing after and before the changes.
  • Included a description of change below.
  • Tried to squash the commits.
  • Added Screenshot / Path to tile to Indicate Location of Change in Game

Changes done in this Pull Request

I have resized all the images to the required sizes.

Work in progress!

@YashKumarVerma
Copy link
Member

It's a good practice to complete the work and then open a pull request, as it notifies the maintainers on every commit/action, which is not appreciated.

@samyakbvs
Copy link
Contributor Author

@YashKumarVerma I open the pull request first in order to check how my work reflects on the preview link

@samyakbvs
Copy link
Contributor Author

Travis is able to execute img_checker without any obstructions, but this gives rise to two more issues: #1070 and the tiles in the game have been displaced from their correct position from their current position.

@YashKumarVerma do you think I should fix the problem of displacement in this PR itself or should I start another one; I am a bit lost on why the problem of displacement is occurring, a little guidance would be helpful:).

@samyakbvs samyakbvs mentioned this pull request Dec 5, 2019
@xeon-zolt xeon-zolt added the WIP label Dec 6, 2019
@samyakbvs
Copy link
Contributor Author

@YashKumarVerma ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Failing
3 participants