Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds QR code support to backend #2117

Closed
wants to merge 1 commit into from

Conversation

abishekvashok
Copy link
Member

Fixes #2116

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

Adds qr code support for backend. An optional flag qr_code shall be
passed which specifies whether qr code support must be added to the
badges.

qr_code text shall be specified by the same parameter.

Adds qr code support for backend. An optional flag qr_code shall be
passed which specifies whether qr code support must be added to the
badges.

qr_code text shall be specified by the same parameter.

Signed-off-by: Abishek V Ashok <[email protected]>
Fixes fossasia#2116
@kushthedude
Copy link
Member

Not required, Why are you adding new functionalities when the website is broken ?
What our primary concern is making badgeyay alive, Cant you understand such simple facts.

@abishekvashok
Copy link
Member Author

Yes I agree on that. Instead of saying that badgeyay is down I see that only some functionalities are down, we need to fix them one by one, following on the best practices it is imperative to develop features in parallel as the website is still testable. Does that mean all features should be stripped and new ones stalled? I don't see it that this pr should be removed and not be opened again.

@kushthedude
Copy link
Member

Do you ever understand what I say, I closed it so that complete focus could be on making website live.
You need to read them again I suppose,why do you want a feature when the website is already down. Where will you use QR on your local machine?

@kushthedude
Copy link
Member

But since you dont understand basic of devops, Let it remain open but for god's sake don't merge until badgeyay has underwent extensive testing and all the systems are working as they are meant to be

@kushthedude
Copy link
Member

Reopen when #2119 is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add QR code support for backend
2 participants