fix: handle invalid manifest.json files in checkIncompatibleAddOns function #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revyn112
changed the title
frankkopp
approved these changes
Nov 17, 2024
|
Great change - was looking at this just the other day as I also had an issue in my own Community folder that threw an error. |
frankkopp
pushed a commit
that referenced
this pull request
Nov 17, 2024
…nction (#495) * fix: check parsing for incorrect manifest.json of 3rd party addons * fix: run lint --------- Co-authored-by: Frank Kopp <[email protected]> (cherry picked from commit 5d4e807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Error Handling for manifest.json Parsing:
Added a try-catch block to handle cases where
manifest.jsonis invalid or unreadable.Prevented the function from crashing due to syntax errors or unexpected tokens in manifest.json.
Logging Improvements:
Implemented
console.warnto log issues with specificmanifest.jsonfiles for debugging purposes.Resilience Enhancements:
Ensured the function gracefully continues processing other directories even if a corrupt
manifest.jsonis encountered.These changes improve the reliability and robustness of the
checkIncompatibleAddOnsfunction.Screenshots (if necessary)
Before:
After:
Additional context
Discord username (if different from GitHub):