refactor: remove antd and antd icons #452
Conversation
Benjozork
force-pushed
the
refactor/remove-antd
branch
from
cb61934 to
8199c0b
Compare
There was a problem hiding this comment.
Font size issues in several places like settings, simbridge settings, simbridge release notes etc. Generally font sizes are observed to be smaller, buttons also affected. Please compare with latest release.
| PR | 3.3.8 |
|---|---|
 |
 |
 |
 |
 |
 |
Also the full screen crash report that currently occurs on initial start when updating from the latest release to master has UI issues.
| 3.3.8 -> PR | 3.3.8 -> master |
|---|---|
 |
 |
Changes on InstallerUpdate LGTM and are tested by auto-updating PR -> 3.3.8. No issues observed.
|
@FoxtrotSierra6829 I fixed the styling issues, however I could not reproduce the issue coming from latest release |
src/renderer/index.tsx
Outdated
| @@ -72,6 +72,8 @@ ipcRenderer.invoke(channels.sentry.requestSessionID).then((sessionID) => { | |||
|
|
|||
| // Obtain configuration and use it | |||
| InstallerConfiguration.obtain().then((config: Configuration) => { | |||
| throw new Error('a'.repeat(255)); | |||
There was a problem hiding this comment.
lol, yeah, probably...
There was a problem hiding this comment.
Still some small issues
-
Don't show again (tickbox) too small in SimBridge autostart modal (can be disregarded if issue is opened to replace it with the normal don't show again (toggle) version from other modals)
-
Location for temporary folders path to small (visibible if option above is enabled)
-
Configuration download URL path too small
-
Error code in modal spills over
# Conflicts: # src/renderer/components/Modal/ErrorDialog.tsx
Summary of Changes
antdand@ant-design/iconsand their remaining usages, to save about 8MB on the final exe size and be able to upload to CF again