Add custom parameter error #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65957107 |
JasonKChow
force-pushed
the
export-D65957107
branch
from
311ee27
to
fedff8c
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly. ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error. Differential Revision: D65957107
|
This pull request was exported from Phabricator. Differential Revision: D65957107 |
JasonKChow
force-pushed
the
export-D65957107
branch
from
fedff8c
to
432fd6e
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
Summary: Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly. ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error. Differential Revision: D65957107
|
This pull request was exported from Phabricator. Differential Revision: D65957107 |
Summary: Pull Request resolved: facebookresearch#445 Discrete parameter support added via rounding transform. Differential Revision: D65699942
…okresearch#452) Summary: Pull Request resolved: facebookresearch#452 Transforming bounds requires additional logic that used to be part of ParameterTransforms, we move these to the parameters itself and have the ParameterTransforms look for these special methods when transforming bounds. We add a new ABC for our transforms as going forward it is likely that all of our transforms will have unique capabilities over the BoTorch base. Differential Revision: D65897908
Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
… tensors Summary: This removes the numpy dependency from the manual generators and changes the logic slightly so that we can support higher dimensional tensors of points, allowing us to support pairwise experiments Differential Revision: D64607853
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
|
This pull request was exported from Phabricator. Differential Revision: D65957107 |
JasonKChow
force-pushed
the
export-D65957107
branch
from
432fd6e
to
912977a
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
Summary: Pull Request resolved: facebookresearch#456 Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly. ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error. Reviewed By: crasanders Differential Revision: D65957107
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
Summary: Pull Request resolved: facebookresearch#456 Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly. ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error. Reviewed By: crasanders Differential Revision: D65957107
JasonKChow
force-pushed
the
export-D65957107
branch
from
912977a
to
7a4e846
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65957107 |
Summary: Pull Request resolved: facebookresearch#456 Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly. ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error. Reviewed By: crasanders Differential Revision: D65957107
|
This pull request was exported from Phabricator. Differential Revision: D65957107 |
JasonKChow
force-pushed
the
export-D65957107
branch
from
7a4e846
to
ce885e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly.
ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error.
Differential Revision: D65957107