Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buffer): use node:buffer instead of safe-buffer #1000

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ymeskini
Copy link

@ymeskini ymeskini commented Oct 31, 2024

Since express@5 will support a minimum of nodejs version 18, I think it would be safe to use node:buffer

Cc @wesleytodd @UlisesGascon

@bjohansebas
Copy link
Member

This would require dropping support for older versions, because it still supports Node.js versions that have vulnerabilities with the buffer

index.js Outdated Show resolved Hide resolved
@UlisesGascon
Copy link
Member

Hey @ymeskini! Thanks for your PR!

The session library is still compatible with [email protected] so this change can't be merged until the next major (in case that we drop support for old Node.js versions).

So, I will move this PR to draft to avoid accidental merges 👍

@UlisesGascon UlisesGascon self-assigned this Nov 9, 2024
@UlisesGascon UlisesGascon marked this pull request as draft November 9, 2024 12:12
@wesleytodd
Copy link
Member

Additionally before this could be merged, we would need to also remove it from the package.json. But I agree, leaving it in draft until the next major (which may honestly be quite a while) is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants