Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chess_game.rb #1738

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Horlamedhey
Copy link

@Horlamedhey Horlamedhey commented Jan 12, 2025

The method 'nick_name' is not consistent with the instructions' version (nickname), and since 'nickname' is a whole word, it makes sense without the underscore.

Discussion for approval: https://forum.exercism.org/t/update-chess-game-rb/14696

The method 'nick_name' is not consistent with the instructions' version (nickname), and since 'nickname' is a whole word, it makes sense without the underscore.
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 12, 2025
@kotp kotp reopened this Jan 12, 2025
@kotp kotp self-requested a review January 12, 2025 18:56
@kotp
Copy link
Member

kotp commented Jan 15, 2025

Whenever you think it is ready for review, go ahead and click the "Ready for review" button to get this out of "Draft".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants