Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming of extension functions #775

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

ErikSchierboom
Copy link
Member

No description provided.

docs/GENERATORS.md Outdated Show resolved Hide resolved
@ErikSchierboom ErikSchierboom force-pushed the improve-extension-function-naming branch from 93219b6 to 1176404 Compare January 18, 2025 10:04
@ErikSchierboom
Copy link
Member Author

@tasxatzial Later on, we can consider adding specialized update functions for updating the path (which determines the rendered testing string argument) and/pr expected.error value, which are likely quite common transformations. But let's hold off on that until we've done more templates.

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot more sense now

@ErikSchierboom ErikSchierboom force-pushed the improve-extension-function-naming branch from 1176404 to bd75601 Compare January 18, 2025 14:04
@ErikSchierboom ErikSchierboom merged commit 1f0fc5c into main Jan 18, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the improve-extension-function-naming branch January 18, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants