Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple-cipher exercise #772

Merged
merged 5 commits into from
Jan 18, 2025
Merged

Add simple-cipher exercise #772

merged 5 commits into from
Jan 18, 2025

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom force-pushed the simple-cipher branch 3 times, most recently from 0b92183 to e861317 Compare January 17, 2025 09:29
Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, i did not miss anything.

We should probably use something more distinct than a simple dash to separate parent and child descriptions. If descriptions also have dashes, it'll make the full description difficult to parse. How about using >> (or the more distict )

"uuid": "ce982624-94ac-4bcd-8946-0a20f99545d7",
"practices": [],
"prerequisites": [
"conditionals",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit the reasoning behind the conditionals?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove that. Originally I had used conditionals, but they're not needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution does not use them, but i'm wondering if conditionals are useful in case someone does not come up with a similar solution. I haven't solved the exercise, so i'm not sure. Your call.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably not needed

exercises/practice/simple-cipher/.meta/generator.tpl Outdated Show resolved Hide resolved
exercises/practice/simple-cipher/src/simple_cipher.clj Outdated Show resolved Hide resolved
exercises/practice/simple-cipher/src/simple_cipher.clj Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member Author

@tasxatzial I've created a PR to update the separator: #779 Let's get that merged first and then I'll update this Pr and the dnd-character one

Copy link
Member

@tasxatzial tasxatzial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ErikSchierboom ErikSchierboom merged commit ac40704 into main Jan 18, 2025
2 checks passed
@ErikSchierboom ErikSchierboom deleted the simple-cipher branch January 18, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants