-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple-cipher
exercise
#772
Conversation
0b92183
to
e861317
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, i did not miss anything.
We should probably use something more distinct than a simple dash to separate parent and child descriptions. If descriptions also have dashes, it'll make the full description difficult to parse. How about using >>
(or the more distict ▶
)
"uuid": "ce982624-94ac-4bcd-8946-0a20f99545d7", | ||
"practices": [], | ||
"prerequisites": [ | ||
"conditionals", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain a bit the reasoning behind the conditionals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove that. Originally I had used conditionals, but they're not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution does not use them, but i'm wondering if conditionals are useful in case someone does not come up with a similar solution. I haven't solved the exercise, so i'm not sure. Your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably not needed
@tasxatzial I've created a PR to update the separator: #779 Let's get that merged first and then I'll update this Pr and the |
ac464ca
to
f7fea2b
Compare
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
Co-authored-by: Anastasios Chatzialexiou <[email protected]>
f7fea2b
to
64d495c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.