Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating instructions on how to build Nighthawk. #838

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

mum4k
Copy link
Collaborator

@mum4k mum4k commented Apr 21, 2022

Addresses concerns raised in #832 and #833.

Signed-off-by: Jakub Sobon [email protected]

@mum4k mum4k requested a review from qqustc April 21, 2022 14:57
@mum4k mum4k marked this pull request as ready for review April 21, 2022 14:57
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Apr 21, 2022
@mum4k
Copy link
Collaborator Author

mum4k commented Apr 21, 2022

@qqustc please review and assign back to me once done.

@mum4k mum4k mentioned this pull request Apr 21, 2022
@mum4k mum4k merged commit 7d1d9b9 into envoyproxy:main Apr 22, 2022
@mum4k mum4k deleted the building_nighthawk branch April 22, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-review A PR waiting for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants