http/transport tap: Add a new UDP sink #37172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fchen7 <[email protected]>
Signed-off-by: fchen7 <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Thanks for working on this!
I've looked at the PR description and the issue, but couldn't find an answer: why a custom_sink (see a test example) cannot be used?
cc @mattklein123 @xu1zhou as TAP filter code owners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Add an UDP sink for HTTP/Transport Tap
Additional Description:
See more detailed information in issue #36945
Risk Level: low
Testing:
Manual test has been done
Also CPR test is done
see issue 36945 for more information
Docs Changes:
Build is passed
Release Notes:
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]