visited field of State appears to be unnecessary #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmillwood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I was trying to understand how the
Url.Parsercode worked in advance of potentially making some other contributions.I was trying to set the
visitedfield in aStaterecord for a new function I was writing, but I wasn't sure what it was meant to be, so I tried to figure out how it was being used. I couldn't find anything, so I tried removing it to see what would break. To my mild surprise, I succeeded without affecting any functionality.I had a look at the documentation and the blog posts referenced in the README but I couldn't find anything there either, so I decided I'd just ask here. Is the visited field intended for some future or alternative functionality, or is it obsolete, or is there some other story?
If it can be removed, I suggest that doing so would ease maintenance a little, since we'd no longer have to think about what to put in it or what it does.