fixes #1034, prevent warning #1074

tgloeggl · 2024-11-14T10:20:25Z

No description provided.

False PR

dennis531 · 2024-11-14T14:56:25Z

lib/Models/Videos.php

-            if (in_array($entry['role'], $possible_roles) === false) {
-                $result[] = $entry;
+
+        if (is_array($acl)) {


I recommend adding this check to `updateAcl' after

studip-opencast-plugin/lib/Models/Videos.php

Lines 754 to 757 in 8f576dc

public function updateAcl($new_vis = null)

{

$api_client = ApiEventsClient::getInstance($this->config_id);

$current_acl = $api_client->getAcl($this->episode);

to prevent the current acls from being overwritten if the current acls could not be fetched. If the fetch fails the update process should be aborted.

fixes #1034, prevent warning

8f576dc

tgloeggl added type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x labels Nov 14, 2024

tgloeggl added this to the Opencast 3.18 milestone Nov 14, 2024

tgloeggl requested a review from dennis531 November 14, 2024 10:20

dennis531 previously approved these changes Nov 14, 2024

View reviewed changes

dennis531 requested changes Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #1034, prevent warning #1074

fixes #1034, prevent warning #1074

tgloeggl commented Nov 14, 2024

dennis531 Nov 14, 2024

	public function updateAcl($new_vis = null)
	{
	$api_client = ApiEventsClient::getInstance($this->config_id);
	$current_acl = $api_client->getAcl($this->episode);

fixes #1034, prevent warning #1074

Are you sure you want to change the base?

fixes #1034, prevent warning #1074

Conversation

tgloeggl commented Nov 14, 2024

dennis531 Nov 14, 2024

Choose a reason for hiding this comment