Introduce MP Config Property mp.metrics.enable
#782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channyboy
commented
Aug 1, 2023
| mp.metrics.enable=demo.app.*=false;demo.app.testCounter=true | ||
| ---- | ||
|
|
||
| CAUTION: Before disabling metrics, be aware if your application uses any `getMetric(...)` or `getCounter(...)`/`getHistogram(...)`/`getTimer(...)`/`getGauge(...)` method calls that try to retrieve a specific metric. Due to the _disabled_ metric not being registered this may cause an `IllegalArgumentException`. |
There was a problem hiding this comment.
Suggest using enabled (with a trailing d) in the config key.
We've talked about choosing config key names which describe states of things (enabled) rather than actions to perform on things (enable).
Channyboy
force-pushed
the
v510-enableDisableMetric
branch
from
babbee6
to
355f797
Compare
|
Slated for future release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCK will be delivered in another PR
For #686