-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GUID for summary queries during deployment #588
Open
linyguo
wants to merge
9
commits into
eclipse-symphony:main
Choose a base branch
from
linyguo:users/lingyun/guid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linyguo
force-pushed
the
users/lingyun/guid
branch
from
December 25, 2024 08:03
d72313d
to
1a87014
Compare
update materialize test update materialize test update materialize update materialize
linyguo
force-pushed
the
users/lingyun/guid
branch
from
December 25, 2024 08:20
1a87014
to
0455332
Compare
update test update test
linyguo
force-pushed
the
users/lingyun/guid
branch
from
December 26, 2024 07:17
c10f176
to
0f29c8c
Compare
msftcoderdjw
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's consider helm chart upgrading path and symphony standalone (which doesn't have mutation webhook).
My idea is,
- Add guid in mutation webhook.
- Get summary: if the object has no guid, use name to query, return the first found result.
- Delete summary: if the object has no guid, use name to query, then delete both.
- Upsert summary: If no guid, use name to upsert, otherwise use guid.
linyguo
force-pushed
the
users/lingyun/guid
branch
from
January 17, 2025 02:11
d378717
to
7970e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #562
Add GUID for objects.
TODO: