Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GUID for summary queries during deployment #588

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

linyguo
Copy link
Contributor

@linyguo linyguo commented Dec 19, 2024

Fix #562

Add GUID for objects.

  • during deployment, check if the object has GUID. If it doesn't have a GUID, create a GUID in the annotations
  • during reconciliation, use GUID to identify the object summary instead of the name.

TODO:

  • add GC for deprecated summary

@linyguo linyguo marked this pull request as ready for review December 24, 2024 05:47
@linyguo linyguo marked this pull request as draft December 24, 2024 05:48
update materialize test

update materialize test

update materialize

update materialize
@linyguo linyguo marked this pull request as ready for review December 26, 2024 01:51
update test

update test
Copy link
Contributor

@msftcoderdjw msftcoderdjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider helm chart upgrading path and symphony standalone (which doesn't have mutation webhook).
My idea is,

  1. Add guid in mutation webhook.
  2. Get summary: if the object has no guid, use name to query, return the first found result.
  3. Delete summary: if the object has no guid, use name to query, then delete both.
  4. Upsert summary: If no guid, use name to upsert, otherwise use guid.

@linyguo linyguo force-pushed the users/lingyun/guid branch from d378717 to 7970e8b Compare January 17, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disordered delete and update jobs cannot be recognized by object names
2 participants