Add cancel token for reconcile #541
Open
+301
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemindD
reviewed
Nov 5, 2024
linyguo
force-pushed
the
users/lingyun/cancel
branch
from
831e1b1 to
210d6ab
Compare
linyguo
changed the title
Haishi2016
reviewed
Nov 14, 2024
linyguo
force-pushed
the
users/lingyun/cancel
branch
from
1e5bef7 to
94a37ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #498
Add cancelation mechanism for reconcile:
Add a timeout limit (60min or other values) for reconcile. If the time limit reaches, the context will be canceled and reconcile will be canceled.
Add a tracking mechanism for ongoing jobs. If a delete job is queued, it will check all previous ongoing jobs and cancel them.
Add an interface to call cancel from client request
TODO
Working on tests
Add cancel token for providers